Allow database relinking attempt during import #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes product name for newly created activities * Ensure db metadata is updated when change occurs
This will update metadata to ensure 'depends' is correct
|
This also contains a few bug-fixes for annoyances. |
|
This is turning out to be really annoying. The database import takes place within a thread, so handling exceptions is exceedingly difficult without halting the thread and restarting it later. A possible solution would be to start a hidden 'fixit' thread and make use of the QWaitCondition if any errors take place. (edit) Though having said it, maybe halting the thread, asking for input and restarting it would be a good fix... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to no standard naming scheme for , it is possible for the local BW2Package import to 'fail' because the dependent databases 'do not exist'.
This pull-request allows users to select, for each database that doesn't exist, an alternative. An attempt is then made to relink all of the relevant exchanges in the import using this other database name instead.
If this still results in an error (the new key doesn't exist), then database import will fail as usual.